-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW1 #17
base: master
Are you sure you want to change the base?
HW1 #17
Conversation
@raykim1996 I fixed your gh-pages deploy, so it's live now at https://github.com/raykim1996/hw01-noisy-planet Please see the last two commits I pushed to your branch. The deploy step will delete all files that are tracked by git (see this line). So perhaps contrary to what you might think, you DO NOT want to check in the generated bundle.js files. Instead, we want to add them to @emmaholthouser16 it looks like you experienced the same problem. |
Really lacking the toolbox functions, which is a major point of the assignment. Also missing noise normals implementation. There are some issues with your blinn shading model (notice the bad shadow terminator), and the moon is also unshaded. The highlight looks correct but without selective specularity or noise normals it's uncanny. I see you've put a lot of effort into differentiating the biomes, which is the saving grace here. |
No description provided.