Fix config caching in vmCalcB (#60)

In original version, all of configs[NCONFIGS] point to tempJones, which is apparently not expected behaviour for caching configs. This implementation allocates new memory for each config. Signed-off-by: fxzjshm <[email protected]>
CIRA-Pulsars-and-Transients-Group · Nov 14, 2024 · e506d34 · e506d34
1 parent dc94d9f
commit e506d34
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/primary_beam.c b/src/primary_beam.c
@@ -101,7 +101,6 @@ void vmCalcB(
         configs[config_idx] = NULL;
 
     double * tempJones;
-    tempJones = malloc(8*sizeof(double));
 
     // Normalise to zenith
     int zenith_norm = 1;
@@ -151,12 +150,14 @@ void vmCalcB(
             {
                 // Use the 'dead' configuration temporarily
                 config_idx = DEAD_CONFIG;
+                tempJones = malloc(8*sizeof(double));
                 errInt = calc_jones(pb->beam, az, za, pb->freq_hz, pb->delays[rf_input], pb->amps[rf_input],numAmps, zenith_norm, arrayLatitudeRad ,iauOrder , tempJones);
                 configs[config_idx]=(gpuDoubleComplex *)(tempJones);
             }
             else if (configs[config_idx] == NULL) // Call Hyperbeam if this config hasn't been done yet
             {
                 // Get the calculated FEE Beam (using Hyperbeam)
+                tempJones = malloc(8*sizeof(double));
                 errInt = calc_jones(pb->beam, az, za, pb->freq_hz, pb->delays[rf_input], pb->amps[rf_input],numAmps, zenith_norm, arrayLatitudeRad ,iauOrder , tempJones);
                 configs[config_idx]=(gpuDoubleComplex *)(tempJones);
 
@@ -187,7 +188,8 @@ void vmCalcB(
             cp2x2( configs[config_idx], &(pb->B[PB_IDX(p, ant, 0, nant, npol)]) );
         }
     }
-    free(tempJones);
+    for (config_idx = 0; config_idx < NCONFIGS; config_idx++)
+        free(configs[config_idx]);
 }
 
 /**