Refactor group timeouts #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonsturgeon
force-pushed
the
chore/refactor-group-timeout
branch
from
dac6e1d
to
c7df473
Compare
brandonsturgeon
force-pushed
the
chore/refactor-group-timeout
branch
from
c7df473
to
5e242e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group timeouts were a hacky feature. I probably added it as a band-aid fix to stuck test runs.
However, it also introduced unexpected and arguably undocumented functionality.
When a user reads that async test cases have a default timeout of 60 seconds, they assume that omitting
timeout =from their test case would simply make that value default to 60.Instead, there was a per-group timer that would continue to the next test group if it expired. This isn't technically the same behavior, and should be simplified.
With this change, a timer is created for every single case with no group timeout.