Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPT wiring #554

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

IPT wiring #554

wants to merge 1 commit into from

Conversation

chivay
Copy link
Collaborator

@chivay chivay commented May 12, 2021

🔨

@manorit2001
Copy link
Contributor

@chivay wasn't this fixed in #556 ? ( lints not to be required for E2E tests )

@chivay
Copy link
Collaborator Author

chivay commented May 26, 2021

What do you mean by "this"?

@manorit2001
Copy link
Contributor

What do you mean by "this"?

lints not to be required for E2E tests, ( i know not in the context of PR, apologies for that ). I just saw that E2E tests weren't being run so just asked

@chivay
Copy link
Collaborator Author

chivay commented May 26, 2021

Hmm, maybe the branch was somehow not rebased. It seems that there are no dependencies on linting in .drone.yml.
EDIT: Interesting. e2e tests should be executed.
EDIT2: Honestly, no idea. looks like a bug in drone? 🤔

@manorit2001
Copy link
Contributor

manorit2001 commented May 26, 2021

EDIT2: Honestly, no idea. looks like a bug in drone?

Same here tbh, I also could not find any dependency, and drone should not be skipping tasks like that when I had google about it

EDIT: ig we can keep the related issue open till we figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants