-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: add basis transformation procedure #984
Draft
AdelekeBankole
wants to merge
7
commits into
CEED:main
Choose a base branch
from
AdelekeBankole:adeleke/transformed-bases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
70aa74e
add basis transformation procedure
AdelekeBankole c7b1451
evaluate HaleTrefethen at points
AdelekeBankole 74b8495
test for Hale Trefethen transform
AdelekeBankole 1eebdd9
test quadrature transformation
AdelekeBankole 6ade65d
add Hale-Trefethen map and quadrature
AdelekeBankole 4c3e40c
add quadrature transform
AdelekeBankole 233a8d6
test sum of weights
AdelekeBankole File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/// @file | ||
/// Test that Hale-Trefethen transform works | ||
/// \test Test that Hale-Trefethen transform works | ||
#include <ceed.h> | ||
#include <math.h> | ||
|
||
int main(int argc, char **argv) { | ||
Ceed ceed; | ||
CeedInt Q = 16; | ||
CeedScalar rho; | ||
CeedScalar *g, *g_prime; | ||
|
||
CeedHaleTrefethenStripMap(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
|
||
CeedDestroy(&ceed); | ||
return 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/// @file | ||
/// Test that quadrature formula is transformed | ||
/// \test Test that quadrature formula is transformed | ||
#include <ceed.h> | ||
#include <math.h> | ||
|
||
int main(int argc, char **argv) { | ||
CeedInt Q = 5; | ||
CeedScalar w_gauss[Q], w_ht[Q]; | ||
CeedScalar q_gauss[Q], q_ht[Q]; | ||
|
||
CeedGaussQuadrature(Q, q_gauss, w_gauss); | ||
CeedGaussHaleTrefethenQuadrature(1.4, Q, q_ht, w_ht); | ||
for (CeedInt i=0; i<Q; i++) | ||
printf("%g (%g) -> %g (%g)\n", q_gauss[i], w_gauss[i], q_ht[i], w_ht[i]); | ||
|
||
CeedScalar w_sum = 0; | ||
for (CeedInt i=0; i<Q; i++) w_sum += w_ht[i]; | ||
if (fabs(w_sum - 2) > 1e-12) printf("Unexpected sum of weights %g\n", w_sum); | ||
return 0; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, every argument has to be documented. I don't know what you intend this function to do; maybe it can be deleted or maybe it needs to take a
CeedBasis
as input and create aCeedBasis
as output.