Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging for a new release #188

Merged
merged 8 commits into from
Jan 5, 2024
Merged

Merging for a new release #188

merged 8 commits into from
Jan 5, 2024

Conversation

chaithyagr
Copy link
Contributor

This is a PR to merge develop to master for a new release

paquiteau and others added 8 commits February 21, 2022 11:20
* added TIF reader/writer

* added ref to electron tomographic data

* fixed docstrings in load save methods

* added scikit-image in required packages

* Update pysap/data.py

Thanks Sam

Co-authored-by: Samuel Farrens <[email protected]>

* Update pysap/base/loaders/tif.py

Co-authored-by: Samuel Farrens <[email protected]>
* first draft of unified docs for PySAP

* fixed typo

* added sphing-gallery for examples

* save progress

* save progress

* add intersphinx mapping for modopt

* updated CD build

* test manual build

* try github event naming

* updated

* update conf

* added sphinx book theme to requirements

* updated CD build

* removed plug-in examples from base repo

* updated workflow

* updated CD workflow

* updated pysap-astro plugin

* changed how pysap sources plugins

* removed stray fits file

* added custom CSS for sphinx-gallery

* first pass fixing pysap api data types and clean up
* deprecated pyqtgraph usage

* build CFITSIO from source

* added bigmac dependency for macOS

* test update to conda activation

* update ci matrix

* clean up code style

* switched to testing framework to pytest

* removed Python 3.6 test case

* check C compilers

* check pysparse installation

* added checking step to CI

* test with LD_LIBRARY_PATH

* Update pysap/plotting/transform.py

Co-authored-by: Pierre-Antoine Comby <[email protected]>

* Update pysap/configure.py

Co-authored-by: Pierre-Antoine Comby <[email protected]>

* add changes suggested by reviewer

Co-authored-by: Pierre-Antoine Comby <[email protected]>
Remove pre-installation of pybind11
* first draft of unified docs for PySAP

* fixed typo

* added sphing-gallery for examples

* save progress

* save progress

* add intersphinx mapping for modopt

* updated CD build

* test manual build

* try github event naming

* updated

* update conf

* added sphinx book theme to requirements

* updated CD build

* removed plug-in examples from base repo

* updated workflow

* updated CD workflow

* updated pysap-astro plugin

* changed how pysap sources plugins

* removed stray fits file

* updated documentation

* added custom CSS for sphinx-gallery

* first pass fixing pysap api data types and clean up

* added landing page and cleaned up

* added banner images

* minor clean up

* cleaned up reference formatting

* added see also sections

* changed example section sorting

* fix get_data-> get_fdata

---------

Co-authored-by: Chaithya G R <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (d72aa52) 61.88% compared to head (d841ba0) 63.52%.

Files Patch % Lines
pysap/extensions/formating.py 0.00% 16 Missing ⚠️
setup.py 0.00% 8 Missing ⚠️
pysap/base/loaders/tif.py 63.63% 4 Missing ⚠️
pysap/plotting/image.py 33.33% 4 Missing ⚠️
pysap/plotting/transform.py 33.33% 4 Missing ⚠️
pysap/base/image.py 50.00% 1 Missing ⚠️
pysap/base/plugins.py 0.00% 1 Missing ⚠️
pysap/base/transform.py 50.00% 1 Missing ⚠️
pysap/configure.py 0.00% 1 Missing ⚠️
pysap/data.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   61.88%   63.52%   +1.64%     
==========================================
  Files          30       36       +6     
  Lines        1658     2185     +527     
==========================================
+ Hits         1026     1388     +362     
- Misses        632      797     +165     
Flag Coverage Δ
unittests 63.52% <65.83%> (+1.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaithyagr
Copy link
Contributor Author

@paquiteau seems like we need one approving review (even though all the work here is approved codes) I will bypass this if needed exceptionally, but if you can just approve in your free time.

@paquiteau paquiteau merged commit 123ad58 into master Jan 5, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants