-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SMALL] Add support for Undecimated Wavelet Transform, with right adjoint operator #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the op
and adj_op
code need to be refactored. A lot of code is used in common between the multichannel and single channel cases.
For example a op_single_channel
and a adj_op_single_channel
could be implemented.
Adding, I see that Travis Build also has failed due to missing Sparse2D installations. I will try to get this fixed here as we may need this in the future also. |
Yes that will have to be explained in the docs somewhere too. |
2) Updates based on Zac's comments 3) Add another test to test multichannel with multi-cpu -> This could fail
Adding @AGrigis to review the travis code updates. @AGrigis : We are awaiting CEA-COSMIC/ModOpt#64 to be merged to mainline so that we can directly point to CEA_COSMIC master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions especially regarding the parallel execution of the wavelet op.
Add backend support for multichannel parallel run Update docs for verbosity level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe let's wait for @AGrigis 's input for the travis part, but I am not too worried as this is a hot-fix
Yes, I'll let @LElgueddari just give a quick look at it. Ill mostly talk off-hand with @AGrigis about this. |
I suggest to test against the master banch of pysap and modopt but also from the released version available on pypi. |
I agree on this, we could use matrix to test with both cases. However, we would need pysap to export the sparse2D binaries to a location for this, (perhaps in |
All codes are in. Travis updated to point to CEA-COSMIC master branch of Modopt. |
Had an offline chat with @LElgueddari , we plan to merge this as there isnt any specific feedback we may require from Loubna for this merge. Merging to Master |
This is a minor PR that will hold the undecimated Wavelet transform class for 2D, which pulls in the transform filters from Sparse2D with help of Modopt.
This is a temporary solution while we wait for general solution from CEA-COSMIC/pysap#106
This PR is particularly important to get the first merge for #35 with cartesian and non-cartesian reconstructions.