Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct env variable definitions in ecs-frontend.yaml #183

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jupiter007
Copy link
Collaborator

@jupiter007 jupiter007 commented Nov 18, 2024

Fixed (#182)

Currently, the ecs-frontend template includes several environment variables:

            - Name: 'NEXT_PUBLIC_BASE_URL'
              Value: !Ref NextPublicBaseUrl
            - Name: 'NEXT_PUBLIC_SERVER_ENDPOINT'
              Value: !Ref NextPublicServerEndpoint
            - Name: 'NEXT_PUBLIC_GRAPHQL_SERVER_ENDPOINT'
              Value: !Ref NextPublicGraphqlServerEndpoint

Currently, the env variables in my local .env.local file, are defined as:

NEXT_PUBLIC_BASE_URL="http://localhost:3000"
NEXT_PUBLIC_SERVER_ENDPOINT="http://localhost:4000"
NEXT_PUBLIC_GRAPHQL_SERVER_ENDPOINT="http://localhost:4000/graphql"

The variables in ecs-frontend config were erroneously defined to include = signs, and it's throwing off the url, so that it is coming through as https://ui.dmphub.uc3dev.cdlib.net/=%22https://ui.dmphub.uc3dev.cdlib.net%22/apollo-csrf in the request. Will remove the = sign and the double quotes.

I didn't need to add any new env variables at this time.

Copy link
Collaborator

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Juliet.

Go ahead and sign into AWS and copy the dev env credentials to your terminal window. Then run sceptre launch dev/regional/ecs-frontend.yaml to deploy these updates to AWS.

I'm not sure if it will automatically trigger an ECS redeploy. I think so, but give it like 10-15 minutes after you've run the Sceptre script and see if the issue is resolved. If not let me know and we can try to trigger it manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants