Add GMT+12 MOJURO TimeZone to ReportStream #16864
Conversation
oslynn
added
the
onboarding-ops
oslynn
requested review from
etanb,
the-andrew,
victor-chaparro,
lucero-v,
abiphilipnava and
kobiehorne
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| @@ -273,4 +274,11 @@ internal class ReceiverTests { | |||
| val receiver = Receiver("elr", "IGNORE", Topic.COVID_19, CustomerStatus.INACTIVE, translatorConfig) | |||
| assertThat(receiver.transportType.type).isEqualTo("NULL") | |||
| } | |||
|
|
|||
| @Test | |||
| fun `test MOJURO receiver timezone`() { | |||
There was a problem hiding this comment.
Minor: test name typo.
Also, why is it testing isNotEqualTo if it's creating a time in MHT and comparing it to what appears to be the same datetime?
There was a problem hiding this comment.
Thank you very much, Andrew. It is fixed.
| val shouldWork1 = | ||
| ZonedDateTime.of(2024, 12, 20, 0, 0, 0, 0, ZoneId.of(USTimeZone.MAJURO.zoneId)).toOffsetDateTime() | ||
| assertThat(shouldWork1).isNotEqualTo("2024-12-20T00:00+12:00") | ||
| } |
There was a problem hiding this comment.
What is this test actually testing? Is testing that it works or that it doesn't work?
There was a problem hiding this comment.
Test to see, it is working.
There was a problem hiding this comment.
Shouldn't it be testing that the date gets converted to MAJURO than?
There was a problem hiding this comment.
Oh yes, are you correct. I will test the date get converted to MAJURO as well. Thanks.
There was a problem hiding this comment.
Added the test the date get converted to MAJURO. Done.
|
Branch deployed to Chromatic 🚀.
View via: |
|
|
oslynn
deleted the
oo/oslynn/16825/Add_GMT+12_MOJURO_TimeZone_To_ReportStream
branch
* Add GMT+12 MOJURO TimeZone to ReportStream * Added the enrichment schema for MAJURO timezone * Fixed Test name
This PR adds MOJURO timezone to reportStream since Marshall Island needs GMT+ 12 (MAJURO) timezone to be added to their message if we receive a message that has a date filed with a timezone. However, ReportStream doesn't support or allow to setting the timezone, yet.
Test Steps:
./gradlew prime-router:test --tests "gov.cdc.prime.router.ReceiverTests.test MAJURO receiver timezone"
Changes
Checklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?npm run lint:write?Process
Linked Issues
To Be Done
Create GitHub issues to track the work remaining, if any
Specific Security-related subjects a reviewer should pay specific attention to
If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least: