Update the API Guide with Code mapping template & instructions #16850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etanb
added
experience
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jillian-hammer
requested changes
Dec 18, 2024
There was a problem hiding this comment.
thanks @etanb this is looking great! a few notes:
- Step 1: Some of the text is missing the bold styling. ("Note: If you’re testing OTC data, use the NIST HL7 General Validation Tool and select RADx MARS HL7v2 from the Tool Scopes dropdown. Navigate to the Context-free tab and select the Onboarding profile group. Correct any errors you receive.")
- Step 2.2: Remove period after header
Set up your file - Can you double check that that anchor links for the accordions is working and are unique to that accordion? For example, when I open accordion for Step 2.1, the URL changes to
developer-resources/api/getting-started#1but that is the same URL when I open Step 3.1. and when I try to open that link in a new tab, it does not auto link to that open accordion. it just opens the page from the top.
| (Note: If you’re testing OTC data, use the <A href={site.external.nistGeneralValidationTool.url}>NIST HL7 General Validation Tool</A> and | ||
| select “RADx MARS HL7v2” from the tool scope dropdown. Navigate to the “Context-free” tab and select the “Onboarding” profile group). | ||
| Note: If you’re testing OTC data, use the <A href={site.external.nistGeneralValidationTool.url}>NIST HL7 General Validation Tool</A> and | ||
| select** RADx MARS HL7v2** from the **Tool Scopes** dropdown. Navigate to the **Context-free** tab and select the **Onboarding** profile group. |
There was a problem hiding this comment.
- fix bold styling (screenshot from preview link below)
jillian-hammer
approved these changes
Dec 19, 2024
victor-chaparro
approved these changes
Dec 19, 2024
|
Branch deployed to Chromatic 🚀.
View via: |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the API Guide.
Fixes #16628