Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline filtering, create params flags for tools #148

Closed
wants to merge 40 commits into from

Conversation

slsevilla
Copy link

@slsevilla slsevilla commented Mar 28, 2024

Changes

This PR includes the following changes:

  • refactors filtering failed samples for fairy
  • refactors ICA handling, terra handling
  • add a param flags in nextflow.config
    • execution-based
      • run_busco
      • ncbi_excel_creation
      • extended_qc
      • run_srst2_mlst
      • run_griphin
    • feature-based
      • save_trimmed_fail
      • save_merged
      • save_output_fastqs
      • save_reads_assignment
  • moves parameter checks upstream to main.nf
    • ICA
    • TERRA

Issues

This PR addresses the following issues:

Scope

These changes have only been tested on the --entry PHOENIX part of the pipeline, on an AWS EC2 instance.

Checklist

The following points were addressed in this PR:

  • Description of the changes with justifications and issue links, where applicable
  • Updated docs related to these changes
  • Updated CHANGE.md with changes outlined above and a reference to the PR number.

@slsevilla slsevilla marked this pull request as draft March 28, 2024 21:06
@slsevilla slsevilla marked this pull request as ready for review April 9, 2024 03:35
@slsevilla
Copy link
Author

hey @jvhagey - this is ready for review!

@slsevilla
Copy link
Author

Closing PR since updates listed here were submitted as separate commits / will not be updated.

@slsevilla slsevilla closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant