Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: convert some data for lighthouse, update links #3149

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Jan 17, 2025

PULL REQUEST

Summary

Re-enable our usage of lighthouse so we get meaningful data. Convert the e2e seed data before running and hit our viewer, library, and 404 pages.

Related Issue

Fixes #2869

Acceptance Criteria

Lighthouse tests a fully loaded ecr

Additional Information

image image image image

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (035ce29) to head (96053b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
+ Coverage   87.06%   89.29%   +2.22%     
==========================================
  Files         221       84     -137     
  Lines       13719     4288    -9431     
  Branches      737      725      -12     
==========================================
- Hits        11945     3829    -8116     
+ Misses       1765      450    -1315     
  Partials        9        9              
Flag Coverage Δ
ecr-viewer 91.09% <ø> (ø)
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 137 files with indirect coverage changes

@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit dd61a7b Jan 21, 2025
16 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/fix-lighthouse branch January 21, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Lighthouse
2 participants