Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boban/refactor qp #3125

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Boban/refactor qp #3125

wants to merge 17 commits into from

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Jan 13, 2025

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.98%. Comparing base (e1385f0) to head (b8faba9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../ecr-viewer/src/app/services/listEcrDataService.ts 50.00% 2 Missing ⚠️
...ntainers/ecr-viewer/src/app/components/DataRow.tsx 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
+ Coverage   87.03%   89.98%   +2.95%     
==========================================
  Files         221       86     -135     
  Lines       13664     4155    -9509     
  Branches      708      706       -2     
==========================================
- Hits        11892     3739    -8153     
+ Misses       1763      396    -1367     
- Partials        9       20      +11     
Flag Coverage Δ
ecr-viewer 92.23% <97.14%> (+1.24%) ⬆️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ers/ecr-viewer/src/app/components/BaseEcrTable.tsx 100.00% <100.00%> (ø)
...viewer/src/app/components/EcrPaginationWrapper.tsx 100.00% <100.00%> (+11.11%) ⬆️
...tainers/ecr-viewer/src/app/components/EcrTable.tsx 100.00% <100.00%> (ø)
...ecr-viewer/src/app/components/EcrTableSkeleton.tsx 100.00% <100.00%> (ø)
...rs/ecr-viewer/src/app/components/LibrarySearch.tsx 100.00% <100.00%> (ø)
...iners/ecr-viewer/src/app/components/SortButton.tsx 100.00% <100.00%> (+82.35%) ⬆️
containers/ecr-viewer/src/app/page.tsx 100.00% <100.00%> (ø)
...ntainers/ecr-viewer/src/app/components/DataRow.tsx 93.75% <93.75%> (ø)
.../ecr-viewer/src/app/services/listEcrDataService.ts 74.58% <50.00%> (+0.55%) ⬆️

... and 145 files with indirect coverage changes

Comment on lines 86 to 87
await page.goto("/ecr-viewer?itemsPerPage=25");
await page.waitForURL("/ecr-viewer?itemsPerPage=25");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wait isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant