feat: Add periods to patient addresses #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
- Coverage 86.00% 83.50% -2.51%
==========================================
Files 162 132 -30
Lines 10855 8188 -2667
==========================================
- Hits 9336 6837 -2499
+ Misses 1519 1351 -168
Flags with carried forward coverage won't be shown. Click here to find out more. |
mcmcgrath13
commented
Dec 11, 2024
mcmcgrath13
commented
Dec 11, 2024
containers/fhir-converter/Dockerfile
Outdated
| @@ -1,7 +1,7 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build | |||
|
|
|||
| # Download FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch v7.0-skylight-15 --single-branch /build/FHIR-Converter | |||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch mcm/econ-periods --single-branch /build/FHIR-Converter | |||
There was a problem hiding this comment.
todo: update this with released version once merged
mcmcgrath13
requested review from
BobanL,
angelathe,
JNygaard-Skylight,
lina-roth,
gordonfarrell and
austin-hall-skylight
and removed request for
angelathe
JNygaard-Skylight
requested changes
Dec 12, 2024
containers/ecr-viewer/src/app/services/evaluateFhirDataService.ts
Outdated
Show resolved
Hide resolved
…o mcm/econ-periods
mcmcgrath13
commented
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Add the useable period to a patient's addresses if available. Counterpart of skylight-hq/FHIR-Converter#20
Refactored
formatAddressto be a bit more flexible and terser to use on the common case in the process.Related Issue
Fixes #2913
Acceptance Criteria
We would like to display all information that is available to (consult w/ design first).
Additional Information