Add's line breaks to comment text #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbristow
requested review from
BobanL,
angelathe,
gordonfarrell and
sarahtress
|
@nickbristow could you add some screenshots so I can review? thanks! |
|
@sarahtress So we don't have a ton of data outside the HTML version, but I can see that they are separate strings and they are using |
|
this looks right to me! |
BobanL
reviewed
Jul 17, 2024
| { | ||
| stringBuilder.Append(ToHtmlString(row)); | ||
| stringBuilder.Append(ToHtmlString(listData[i])); |
There was a problem hiding this comment.
Can we try to resolve this warning?
There was a problem hiding this comment.
Should be good now
BobanL
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Adds line breaks to comment text
Summary
When a piece of text has
<br>separators, it adds a paragraph tag around each piece.Related Issue
Fixes #2082
Additional Information
Anything else the review team should know?
Checklist