Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inferencedata_to_tidy_draws #7

Merged
merged 24 commits into from
Nov 15, 2024
Merged

Conversation

damonbayer
Copy link
Contributor

@damonbayer damonbayer commented Nov 13, 2024

No description provided.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damonbayer! A few minor things and one more major request: it would be nice to have a test for this function.

R/inferencedata_df_to_tidy_draws.R Outdated Show resolved Hide resolved
R/inferencedata_df_to_tidy_draws.R Show resolved Hide resolved
R/inferencedata_df_to_tidy_draws.R Outdated Show resolved Hide resolved
R/inferencedata_df_to_tidy_draws.R Outdated Show resolved Hide resolved
@damonbayer damonbayer force-pushed the dmb_inferencedata_to_tidy_draws branch from 90ed486 to b37f18c Compare November 14, 2024 00:05
@damonbayer
Copy link
Contributor Author

damonbayer commented Nov 14, 2024

It might be a good idea to add a release upon merging. Then we can specify the required minimum version in other projects (pyrenew-hew)

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @damonbayer

@dylanhmorris dylanhmorris merged commit df998fd into main Nov 15, 2024
9 checks passed
@dylanhmorris dylanhmorris deleted the dmb_inferencedata_to_tidy_draws branch November 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants