eCR Viewer page layout #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewheeler
commented
Nov 20, 2024
| subheader="An intuitive interface that helps epidemiologists and case investigators make better sense of eCR data, faster." | ||
| /> | ||
| <ContentContainer align> | ||
| <div className="grid grid-cols-1 gap-6 lg:grid-cols-[1fr_3fr_1fr] lg:gap-0"> |
There was a problem hiding this comment.
Once we have at least one more product page that is ready to be worked on, I think it'll make sense at that point to break some of these layout elements out into their own components to use across the product pages.
jakewheeler
commented
Nov 20, 2024
Comment on lines
+270
to
+272
| <Link href="/"> | ||
| Non Integrated Viewer Installation Guide | ||
| </Link> |
There was a problem hiding this comment.
We don't have URLs available to us yet, so we'll have to revisit this section.
nickbristow
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the eCR Viewer page layout. I've also updated the products page URL from
/our-productsto/products.Testing
Some general things to check: