Create LinkButton component #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewheeler
commented
Nov 7, 2024
| return ( | ||
| <Link | ||
| href={href} | ||
| className="usa-button hover:bg-red items-center justify-start gap-2.5 rounded border-2 border-[#224a58] bg-white px-5 py-3 hover:border-2" |
There was a problem hiding this comment.
Is there a way to tell in Figma what the hover state of the button should look like? I put very obvious placeholders (like the hover:bg-red here) that I figured we could update later. If we already have this info somewhere, let me know and I can make the update!
There was a problem hiding this comment.
I don't think there is. The way i've seen designers do it is they specifically have a section with all the button states. I don't see that on figma for this
jakewheeler
commented
Nov 7, 2024
Comment on lines
+19
to
+20
| className={classNames('text-white', { | ||
| underline: isActive, |
There was a problem hiding this comment.
This is the main change so that we get the underlining. Otherwise, I just cleaned up some styling we didn't need.
nickbristow
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CDCgov/phdi#2872
This PR adds the
LinkButtoncomponent, which is a Next.js link stylized to look like a USWDSButtoncomponent. This component will be used on the following pages:I've updated both the "home" and "our products" pages to make use of this new component.
Note that the
Send inquirybutton on the "Engage with us" page is a form submission button rather than a link, so this component won't be used there.Additionally, I made a small correction to the
NavigationLinkcomponent so that the nav link of the page we're currently looking at will be underlined, which matches the Figma design.Here's an example:
