Allow overwriting inserts #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-goggins
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
LGTM! Just want to get @DanPaseltiner to take a look to make sure we correctly understood what he wanted here.
|
Adding Dan as a reviewer to get any thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overwriting inserts
Summary
This PR modifies the
INSERTstatement of ourInsertValueSetfunction to allow for duplicated uniqueIDs to overwrite those of existing entries. Our DB creation process will go through a fair number of duplicate value sets after pulling down the eRSD, so simply overwriting them with the same data will allow the seeding process to proceed more smoothly than error-ing and breaking the transaction.Related Issue
Fixes #81
Additional Information
I created a test branch here https://github.com/CDCgov/dibbs-query-connector/tree/test-vs-overwrite that removes database seeding in migrations 2 through 6, and instead adds a button to the landing page that tests a couple cases of inserting valuesets and duplicates into the DB. No errors get thrown and viewing the DB in DBeaver shows all rows correctly entered.