Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dibbsConceptType to valuesets table #36

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Oct 18, 2024

PULL REQUEST

Summary

This PR adds a dibbsConceptType column to the valuesets table and populates the column with the appropriate data. The new column, dibbsConceptType is one of the following values: labs, medications, or conditions, and is based off the ersdConceptType (AKA the type column in valuesets). Adding this column and making the data available when queried will allow us to cut down on some of the transformations we complete in order to properly display the data on the CustomQuery page and during query execution.

Related Issue

Fixes #phdi #2788

Acceptance Criteria

  • We'll write a migration that adds the DibbsDisplayType column to the valuesets table
  • We'll write a migration that fills in this field for each row of the valueset table by mapping the value currently stored in the type column (which holds a clinical service abbreviation code) to its appropriate DisplayType.

Additional Information

This ticket will allow Brandon to continue working on phdi #2789

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@m-goggins m-goggins marked this pull request as ready for review October 18, 2024 13:15
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. When we get database creation sorted out we'll need to do some migration refactoring and I suspect we'll be able to fold this into an earlier migration because we'll need to just declare bankruptcy on the DB and start fresh (the nice thing about still being pre MVP is that we can do this).

@m-goggins m-goggins merged commit 7c7036e into main Oct 18, 2024
4 checks passed
@m-goggins m-goggins deleted the marcelle/2788/add-dibbsConceptType branch October 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants