Add internal data model for ValueSet #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-goggins
requested review from
fzhao99,
robertandremitchell,
bamader and
DanPaseltiner
fzhao99
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This PR adds
Concept,ValueSetandValueSetDisplaydata models to our constants. Note: these concepts have not yet been implemented but will be in the follow up ticket phdi #2789at which point the old data model can be deleted.
Related Issue
Fixes # phdi#2760
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
A dataclass for this model has been added to the codebase.
Additional Information
Anything else the review team should know?
Checklist