Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable image publishing on merges to main #30

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Oct 16, 2024

PULL REQUEST

Summary

Followup to #28 that gets the build / publish step working.

Related Issue

Fixes the lowercase issue that was breaking the workflow run

Manual run of the workflow here that resulted in a published image here

@fzhao99 fzhao99 changed the title hardcode the lowercase version enable image publishing on merges to main Oct 16, 2024
@fzhao99 fzhao99 force-pushed the bob/enable-build-on-merge branch from 8265cf7 to ee119ab Compare October 16, 2024 20:20
@fzhao99 fzhao99 marked this pull request as ready for review October 16, 2024 20:26
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fzhao99 fzhao99 merged commit 2976c69 into main Oct 16, 2024
5 checks passed
@fzhao99 fzhao99 deleted the bob/enable-build-on-merge branch October 16, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants