Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove phdi #3

Merged
merged 3 commits into from
Oct 11, 2024
Merged

remove phdi #3

merged 3 commits into from
Oct 11, 2024

Conversation

DanPaseltiner
Copy link
Collaborator

PULL REQUEST

Summary

Removing phdi

Related Issue

Fixes #

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

fzhao99
fzhao99 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def wins the PR for best ratio of "addition by subtraction"

robertandremitchell
robertandremitchell reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to save the packages until we disentangle turbo from the tefca-viewer, but otherwise, looks good

package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@DanPaseltiner DanPaseltiner merged commit 3f3b31a into main Oct 11, 2024
@linear linear bot mentioned this pull request Oct 31, 2024
Closed
4 tasks
@fzhao99 fzhao99 deleted the dan/remove-phdi branch October 31, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertandremitchell robertandremitchell robertandremitchell left review comments

@fzhao99 fzhao99 fzhao99 approved these changes

@m-goggins m-goggins Awaiting requested review from m-goggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanPaseltiner @fzhao99 @robertandremitchell