fix translation methods between query pages #214
+292
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhao99
commented
Dec 12, 2024
| @@ -688,8 +688,7 @@ export async function getCustomQueries(): Promise<CustomUserQuery[]> { | |||
| q.query_data, | |||
There was a problem hiding this comment.
we can just return all the entries in the query table now that we only seed the table with the five demo queries
fzhao99
requested review from
m-goggins,
robertandremitchell,
katyasoup and
nickclyde
and removed request for
robertandremitchell
fzhao99
commented
Dec 12, 2024
| return { | ||
| code: c["code"], | ||
| display: c["display"], | ||
| include: c["include"] ?? true, |
There was a problem hiding this comment.
In the query building flow, we were getting undefined in a bunch of places since c["include"] wasn't natively there. I think the contexts where include isn't defined off the concept group, the default when we're making a trip back from the DB should be true since we want to include any concept that we've fetched.
If folks think differently though happy to change this
robertandremitchell
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
The code that just went in for the new DB tables overloaded a mapping method between @katyasoup and I's PR's that should have been two separate functions. This PR separates them and adds some unit tests to prevent this in the future
Additional Information
Another example of us not having testing infra biting us! Will bring this up at retro
Something else that might have caught this earlier would be more explicitly typing the response from the DB beyond the provided
QueryRow. Would love opinions on how we might type our queries more explicitly to tell application code what the shape of data coming back from the DB looks likeChecklist