componentize query page checkboxes #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhao99
force-pushed
the
bob/que-57-replace-checkboxes-on-customize-query-page-with-checkbox
branch
from
ba65b50 to
0c18ae3
Compare
…uery-page-with-checkbox
…ith-checkbox' of https://github.com/CDCgov/dibbs-query-connector into bob/que-57-replace-checkboxes-on-customize-query-page-with-checkbox
fzhao99
changed the title
fzhao99
changed the title
…ith-checkbox' of https://github.com/CDCgov/dibbs-query-connector into bob/que-57-replace-checkboxes-on-customize-query-page-with-checkbox
fzhao99
commented
Dec 2, 2024
fzhao99
requested review from
m-goggins,
bamader,
katyasoup,
nickclyde,
robertandremitchell and
mikang
and removed request for
m-goggins
|
Styling looks good! Thanks @fzhao99 ! |
|
|
ready for re-review after adding back in the minus state! Screen.Recording.2024-12-04.at.9.36.29.AM.mov |
robertandremitchell
approved these changes
Dec 4, 2024
fzhao99
deleted the
bob/que-57-replace-checkboxes-on-customize-query-page-with-checkbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Refactors the customize query page to use the checkbox component introduced in another PR to fix some accessibility issues related to making the checkbox via CSS.
Also removed a demo test file that we don't need
Also added a config option to set the local FHIR server url for use for in local e2e runs
Related Issue
Fixes #124
Additional Information
Because the checkbox on this page is different than the out-of-box checkbox we have from USWDS, made a vanity component wrapper for use only on this page. Can chat with design to see if we need this elsewhere.
For design
This is changing some of the frontend code for checkbox stylings, so just double check that the checkboxes on the query customization screen match Figma.
Checklist