Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment workflow #109

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

shanice-skylight
Copy link
Collaborator

@shanice-skylight shanice-skylight commented Nov 1, 2024

PULL REQUEST

Summary

This PR will add a workflow that is triggers the workflow named target_workflow in the repo named phdi-playground. See explanation of each step of the workflow below:

Users are prompted to provide two inputs:
-target_service: The service name (e.g., phdi-playground) that identifies the target repository where the workflow should be triggered.
-target_version: The version (e.g., v1.0.0) that will be passed to the target workflow.

Related Issue

Fixes Issue 79

Additional Information

  • A PAT is currently being used for authentication

Checklist

  • [ X] Descriptive Pull Request title
  • [X ] Link to relevant issues
  • [ X] Update documentation

Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @shanice-skylight thanks for your work here. This workflow appears to only be able to be triggered manually, do we have plans to take this one step further and automatically trigger a deployment every time we merge to main and build a new image of the app? Starting with a manual process is totally reasonable to me.

@shanice-skylight
Copy link
Collaborator Author

Yes, once we confirm the workflow acts as expected. I'll change it to automatically trigger when a PR is merged to main.

@shanice-skylight shanice-skylight merged commit ffe2abd into main Nov 5, 2024
5 checks passed
@shanice-skylight shanice-skylight deleted the shanice/deployment-workflow-79 branch November 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update QC's CD
4 participants