-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit EpiNow2 model #26
Conversation
62786bf
to
b108dbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
b108dbd
to
b911f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments mostly on documentation, but this looks good and the code is clean! Excited to see this go!
Co-authored-by: Katie Gostic (she/her) <[email protected]>
for more information, see https://pre-commit.ci
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Adam Howes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great. My only question was about what happens if a user forgets to specify all the necessary fields in one of the input lists to fit_model()
/document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Take in-memory data, parameters, and sampler settings and fit an EpiNow2 model.
This model recapitulates our existing approach. It continues to be careful to avoid several of our key bugs from the last year:
epinow()
I also downgrade model fitting failure to a warning here from an error. This is to enable metadata/output writing despite model failure.