Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metadata easier to use. #121

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Make metadata easier to use. #121

merged 2 commits into from
Dec 13, 2024

Conversation

natemcintosh
Copy link
Collaborator

  • Change formatting of metadata values to be atomic. Test that this is the case. May have to change this at some point, if we ever add non-atomic fields on purpose.
  • Add blob_storage_container as a field to the metadata.
  • Use empty string for paths when non-existant.

Test that all fields are atomic. May have to change this at some point, if we ever add non-atomic fields on purpose.
@natemcintosh natemcintosh linked an issue Dec 11, 2024 that may be closed by this pull request
3 tasks
Copy link

github-actions bot commented Dec 11, 2024

Thank you for your contribution @natemcintosh 🚀! Your pkgdown-site is ready for download 👉 here 👈!
(The artifact expires on 2024-12-20T13:54:02Z. You can re-generate it by re-running the workflow here.)

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

R/pipeline.R Outdated Show resolved Hide resolved
R/pipeline.R Show resolved Hide resolved
Copy link
Collaborator

@athowes athowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the issue:

The metadata also does not store the blob storage container name.

Could my comment above be getting at there being multiple sources of metadata:

  1. Executing the model logic
  2. Orchestrating the pipeline

I think the blob storage containter is meta data associated with 2. whereas at the moment (this PR) I think it's being put in 1.?

@natemcintosh
Copy link
Collaborator Author

Does anyone know what specifically is causing the CI failure? It looks like a duckdb issue, but I have re-run it multiple times, and it still fails. Usually that flaky duckdb test fixes itself after a re-run.

@zsusswein
Copy link
Collaborator

It looks like the flaky test to me (#97). If it's becoming a real problem, I'll try to make time to fix it right after we get Azure CD somewhere stable.

Copy link
Collaborator

@zsusswein zsusswein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your proposed change to metadata handling is the right thing to do next, but this should merge more or less as-is. Let's get something onto main and then iterate?

Let's bump the conversation on how to handle passing the model run metadata out to orchestrate_pipeline in an issue?

@athowes athowes self-requested a review December 13, 2024 11:37
@athowes
Copy link
Collaborator

athowes commented Dec 13, 2024

Agree OK to make new issue for the meta data point. Main thing for me is that I think execute_model_logic should make sense as a function devoid from any Azure interaction.

@natemcintosh
Copy link
Collaborator Author

Added issue #122 for cleaning up the metadata handling.

@natemcintosh natemcintosh merged commit d098ed6 into main Dec 13, 2024
11 checks passed
@natemcintosh natemcintosh deleted the nam-fix-metadata-issues branch December 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata values are (almost) all in lists
3 participants