-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make metadata easier to use. #121
Conversation
Test that all fields are atomic. May have to change this at some point, if we ever add non-atomic fields on purpose.
Thank you for your contribution @natemcintosh 🚀! Your pkgdown-site is ready for download 👉 here 👈! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the issue:
The metadata also does not store the blob storage container name.
Could my comment above be getting at there being multiple sources of metadata:
- Executing the model logic
- Orchestrating the pipeline
I think the blob storage containter is meta data associated with 2. whereas at the moment (this PR) I think it's being put in 1.?
Does anyone know what specifically is causing the CI failure? It looks like a duckdb issue, but I have re-run it multiple times, and it still fails. Usually that flaky duckdb test fixes itself after a re-run. |
It looks like the flaky test to me (#97). If it's becoming a real problem, I'll try to make time to fix it right after we get Azure CD somewhere stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your proposed change to metadata handling is the right thing to do next, but this should merge more or less as-is. Let's get something onto main and then iterate?
Let's bump the conversation on how to handle passing the model run metadata out to orchestrate_pipeline
in an issue?
Agree OK to make new issue for the meta data point. Main thing for me is that I think |
Added issue #122 for cleaning up the metadata handling. |
blob_storage_container
as a field to the metadata.