Language clarification in extract_diagnostics

[athowes]

Clarified:

• "These diagnostics are then flagged if they exceed specific thresholds" makes it sound like the returned dataframe flags each individually (which it doesn't, hence suggest change of language)
• "Exceed specific thresholds": sometimes it's if the value is below a threshold hence I suggest reword to "outside acceptable range"

Two possible refactors / improvements of this function could be:

1. Return a flag for each diagnostic rather than for all of them jointly. Would it ever be useful to know in particular which diagnostic was violated (straight away, I know it could be recovered with some digging)
2. Allowing setting of the thresholds. As a user I imagine this might be useful, like if certain conditions mean that diagnostics are over or under flagging. I can see here it's a bit annoying to do and would probably have to be like a user input list of named values.

[github-actions]

Thank you for your contribution @zsusswein 🚀! Your pkgdown-site is ready for download 👉 here 👈!
_{(The artifact expires on 2024-12-17T15:06:58Z. You can re-generate it by re-running the workflow here.)}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

[zsusswein]

Do you want to rebuild the docs with roxygen2::roxygenize() or should I?

[athowes]

Do you want to rebuild the docs with roxygen2::roxygenize() or should I?

I will.

[athowes]

Note that it's odd that CI didn't fail (I think?) for the above. I would have thought the website would complain that the docs were not up-to-date? If something missing suggest to add.

[zsusswein]

Yeah we need to do this CDCgov/cfa-gam-rt#57