Add metadata output #105
Merged
Add metadata output #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help us save useful metadata into the metadata file. The current code saved nothing.
13 tasks
amondal2
reviewed
Dec 3, 2024
|
Thank you for your contribution @natemcintosh 🚀! Your pkgdown-site is ready for download 👉 here 👈! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
kgostic
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
I haven't run this code but it looks like other have -- thanks for the close reviews @amondal2 and @zsusswein. If you can get the tests to pass I think this looks good!
It was originally put there by copilot, and somehow I missed that it was there the whole time. This should have happened in the Config class PR. Not sure how it got through there.
zsusswein
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us save useful metadata into the metadata file. The current code saved nothing.