Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention us is option #91

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Mention us is option #91

merged 3 commits into from
Oct 25, 2024

Conversation

natemcintosh
Copy link
Collaborator

This has also been a useful way for me to get up to speed on how docker is working for this repo. I think I should be able to pull the cfa-epinow2-pipeline-dependencies image to speed up build and running the regular Dockerfile, but I haven't figured out the right invocation yet. I'll see if I can get make to help us test, document, check inside the container maybe?

@natemcintosh natemcintosh linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@natemcintosh natemcintosh marked this pull request as ready for review October 24, 2024 21:27
Copy link
Collaborator

@zsusswein zsusswein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you felt like figuring that out, I'd appreciate it!

You may also want to check out the Justfile in the gam repo.

@natemcintosh natemcintosh merged commit 5f65bed into main Oct 25, 2024
10 of 11 checks passed
@natemcintosh natemcintosh deleted the nam-mention-US-is-option branch October 25, 2024 12:53
jkislin pushed a commit that referenced this pull request Nov 5, 2024
* added US as an option

* run document

* forgot to update NEWS
jkislin pushed a commit that referenced this pull request Nov 5, 2024
* added US as an option

* run document

* forgot to update NEWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention that "US" is an option in state_abb documentation
2 participants