Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention that "US" is an option in state_abb documentation #34

Closed
athowes opened this issue Sep 12, 2024 · 0 comments · Fixed by #91
Closed

Mention that "US" is an option in state_abb documentation #34

athowes opened this issue Sep 12, 2024 · 0 comments · Fixed by #91
Assignees
@natemcintosh
Labels
documentation Improvements or additions to documentation v0.1.0

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 12, 2024

cfa-epinow2-pipeline/R/read_data.R

Line 21 in c3f0e54

#' @param state_abb A two-letter uppercase abbreviation

The US is not a state so it would seem hard to obviously know that "US" is a valid state_abb. Also do the state abbreviations follow some standard pattern like ISO? Could be worth documenting.
@athowes athowes added the documentation Improvements or additions to documentation label Sep 12, 2024
@natemcintosh natemcintosh self-assigned this Oct 24, 2024
@natemcintosh natemcintosh linked a pull request Oct 24, 2024 that will close this issue
Mention us is option #91
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natemcintosh natemcintosh

Labels
documentation Improvements or additions to documentation v0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention us is option CDCgov/cfa-epinow2-pipeline
3 participants
@athowes @natemcintosh @zsusswein