Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating link-record endpoint to use either schema #66

Merged
merged 16 commits into from
Oct 4, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Oct 3, 2024

Description

Making changes to main.py link-record route so the user can opt to use either of the two schemas, and the code required to interact with them, via a request header. Also adding OpenTelemetry so we can trace the linking algorithm and its performance.

Related Issues

closes #24

Additional Notes

  • The X-Use-Simple-Link request header can be sent with a true value to indicate the new schema should be used.
  • added src/recordlinker/database.py and moved session creation code there.
  • updated the get_block_data function to use the new sqlalchemey querying syntax and resolved an issue where the query could return duplicate rows

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Oct 4, 2024
@ericbuckley ericbuckley added the enhancement New feature or request label Oct 4, 2024
@ericbuckley ericbuckley changed the title Feature/24 main parameters updating link-record endpoint to use either schema Oct 4, 2024
@ericbuckley ericbuckley marked this pull request as ready for review October 4, 2024 02:45
Copy link
Collaborator

@cbrinson-rise8 cbrinson-rise8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ericbuckley ericbuckley merged commit ed95e17 into main Oct 4, 2024
4 checks passed
@ericbuckley ericbuckley deleted the feature/24-main-parameters branch October 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterize main for different schemas
2 participants