seperating matching functions into its own module #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving matching functions into its own module so they can be more easily reused. Keeping these functions separate, from the logic used for linkage, allows us to move forward with creating an alternative set of linkage functions using a new schema. Also, changing the syntax of the algorithm configuration for all value references that map to python functions. The new format is
func:<module_path>.<function_name>
, this not only makes it easy for parsing the algorithm, but also makes it transparent to the author as to where the matching code lives.Related Issues
closes #9
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: