Skip to content

Commit

Permalink
update GH unit test workflow DB (#27)
Browse files Browse the repository at this point in the history
## Description
The latest version of pyway, 0.3.30, is not able to read the existing
migrations directory. Since these migrations are deprecated in favor of
alembic, the easiest path forward is to pin pyway to version 0.3.29
until its removed from the project.

Within #19 we simplified the settings to use the new DB_URI env variable
to define connection settings. We forgot to also update postgres
database setup in the GH testing workflow to follow this pattern.
  • Loading branch information
ericbuckley authored Sep 19, 2024
1 parent 164780e commit f9f3bb3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/check_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
- 5432:5432
env:
POSTGRES_PASSWORD: pw
POSTGRES_DB: testdb

steps:
- name: Checkout code
Expand All @@ -40,11 +39,6 @@ jobs:
- name: Run unit tests
env:
MPI_DB_TYPE: postgres
MPI_DBNAME: testdb
MPI_HOST: localhost
MPI_PORT: 5432
MPI_USER: postgres
MPI_PASSWORD: pw
DB_URI: "postgresql+psycopg2://postgres:pw@localhost:5432/postgres"
run: |
pytest --cov=recordlinker --cov-report=xml tests/unit
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies = [
"fhirpathpy",
"rapidfuzz",
# TODO: replace pyway with alembic for managing database migrations
"pyway"
"pyway==0.3.29"
]

[project.optional-dependencies]
Expand Down

0 comments on commit f9f3bb3

Please sign in to comment.