Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNFT1-3685: Idle timeout logout modal #2184

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

joeaxcdw
Copy link
Collaborator

@joeaxcdw joeaxcdw commented Jan 17, 2025

Description

  • Replace old dialog with a modal per the Figma design.
  • Refactor adding/removing event handlers so they only fire once after component mounted.
  • Clean up existing timeout logic - add a debounce to avoid spamming setTimeout calls on every mouse move.
  • Show configured timeout value in minutes (no longer hardcoded to 2).
  • Add unit tests.

image

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@joeaxcdw joeaxcdw changed the title CNFT1-3685: Idle time logout modal CNFT1-3685: Idle timeout logout modal Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants