Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes addressing issues 97, 98 #99

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fixes addressing issues 97, 98 #99

merged 1 commit into from
Oct 12, 2023

Conversation

gfireman
Copy link
Contributor

packet_types.py: assign bit_offset for array fields
decode.py: allow processing of partial file (+spelling)
converters.py: fixed units documentation

@gfireman
Copy link
Contributor Author

gfireman commented Oct 11, 2023

The CI checks failed on "black" reformatting. I don't have that tool. Could you handle that, please?

And python versions > 3.9 seem to handle relative imports differently, so you'd have to fix that throughout the code.

...never mind, I fixed it myself and squashed the commits.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #99 (275c244) into main (8b9619f) will decrease coverage by 0.44%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   95.87%   95.44%   -0.44%     
==========================================
  Files           7        7              
  Lines         654      658       +4     
==========================================
+ Hits          627      628       +1     
- Misses         27       30       +3     
Files Coverage Δ
ccsdspy/converters.py 100.00% <ø> (ø)
ccsdspy/packet_types.py 95.26% <ø> (ø)
ccsdspy/decode.py 94.54% <40.00%> (-1.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

decode.py: allow processing of partial file (+spelling)
converters.py: fixed units documentation
@ddasilva
Copy link
Collaborator

Thanks a ton!

@ddasilva ddasilva merged commit 21c1dfc into CCSDSPy:main Oct 12, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants