-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements loading variable length packets from CSV #117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 96.05% 96.10% +0.04%
==========================================
Files 7 7
Lines 710 719 +9
==========================================
+ Hits 682 691 +9
Misses 28 28 ☔ View full report in Codecov by Sentry. |
@ddasilva the CI failing seems to be because of the release of pytest 8.1.0 a few hours ago and plugins not having updated releases to match necessary changes, namely |
Totally reasonable. Feel free to edit your branch to pin a version of pytest and repush. It would be on this line: |
@ehsteve Feel free to comment |
I pinged a few of our collaborators over email from Europa Clipper / MMS / Canadian Space Agency to get their thoughts on this new feature. Even if they don't have much to say, it will be good to raise their awareness! |
Thanks @jmbhughes ! |
Purpose
Add support for loading variable length packets from CSV, resolving #115
Packet array shaped can be defined in the data type as
uint(expand)
for expanding fields oruint(OPMODE)
for a reference type, where OPMODE is another field.Changes to codebase
_parse_csv_array_shape
to handle the more complicated array shape logic_parse_csv_array_shape
should failarray_shape
Todos
Notes
I think I've implemented all the expected features. I haven't tested extensively, so I can add some more tests if you think it's appropriate. As always, I'm open to suggestions.