Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Zeroconf support. #77

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Piero512
Copy link

Hey guys

I have created a little addition where the app is able to discover ruTorrent servers through Zeroconf (provided the user has configured them beforehand).

Right now the service type I am using is: _rutorrent_mobile._tcp.
Also, I am specifying an optional TXT record: 'protocol'
Right now the algorithm for building the url to access ruTorrent is:
if port == 80: http://
if port == 443 https://
else
if protocol is not null $protocol://:
else http://:

@pratikbaid3
Copy link
Collaborator

pratikbaid3 commented Mar 12, 2021

@Piero512 I guess you pushed a fresh copy of the iOS root folder as well, which overwrites some of the changes made to the plist and the Podfile required for some of the packages like vlc to function properly, and also the icon for the app has been replaced with the default flutter icon. It would be great if you could revert the changes made to the root iOS folder and only push the changes made inside the lib and pubspec.yaml.

@Piero512
Copy link
Author

Piero512 commented Mar 12, 2021

Huh, it's just that the README on the project asked for that, but will try to rebase my changes.

@Piero512
Copy link
Author

The patch is much smaller now.

@pratikbaid3
Copy link
Collaborator

pratikbaid3 commented Mar 12, 2021

@Piero512 actually the vlc package requires the swift version of the ios root (https://pub.dev/packages/flutter_vlc_player/versions/3.0.3) folder which wasn't merged in the master earlier. Since that is now done, I guess the first two steps are redundant and would need to be removed.

Screenshot 2021-03-12 at 6 41 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants