-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue70 #74
Conversation
Currently, the output files from catalog, grubbers, and mimeo all start with a common prefix to encode the date, input directory, and user. However, the blame matrix is always called |
I fixed an issue in the e2e docs (bdee6d3) and also made minor updates to the changelog notes -- e.g. succinctly describing issue 71 so readers can get the gist of the fix without going to that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran spacesavers2_e2e
on a few different directories. Results all look good, especially liking the krona reports.
I ran spacesavers2_grubbers --limit 0
separately, as none of the directories I tested had duplicate files over the default 5 GiB. It worked as expected.
I wonder if e2e
should have also have a limit argument to pass on to grubbers with the same default value?
It does |
Done in 615f1ca . |
Also, fixes #64 |
Changes
requirements.txt
for easy creation of environment in "spacesavers2" docker (fix chore: create requirements.txt #68, @kopardev)grubbers
--limit
can be < 1 GiB (float) fix grubbers does not allow--limit
< 1 GiB #70grubbers
has new--outfile
argument.grubbers
output file format changed. New original file column added..blamematrix
has now been moved intomimeo
.mimeo
--duplicateonly
logic fix-z
the only duplicates option formimeo
is not correctly implemented. #71mimeo
files.gz always includes the original file as the first one in the filelist.mimeo
now has kronatools compatible output. ktImportText is also run if in PATH to generate HTML report for duplicates only. (fix Krona charts #46, @kopardev)e2e
overhauled, improved and well commented.df
results fix Total sizes of folders do not add up #75ls
size is not "size" anddu
size is called "calculated_size" in the new FileDetails object.