Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue70 #74

Merged
merged 23 commits into from
Feb 8, 2024
Merged

Issue70 #74

merged 23 commits into from
Feb 8, 2024

Conversation

kopardev
Copy link
Member

@kopardev kopardev commented Feb 5, 2024

Changes

@kopardev kopardev added this to the 2024-02 milestone Feb 5, 2024
@kopardev kopardev self-assigned this Feb 5, 2024
@kopardev kopardev marked this pull request as draft February 5, 2024 22:20
@kelly-sovacool
Copy link
Member

Currently, the output files from catalog, grubbers, and mimeo all start with a common prefix to encode the date, input directory, and user. However, the blame matrix is always called blamematrix.tsv -- should this file instead be renamed to include the same common prefix as the other files?

@kelly-sovacool
Copy link
Member

kelly-sovacool commented Feb 7, 2024

I fixed an issue in the e2e docs (bdee6d3) and also made minor updates to the changelog notes -- e.g. succinctly describing issue 71 so readers can get the gist of the fix without going to that issue.

Copy link
Member

@kelly-sovacool kelly-sovacool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran spacesavers2_e2e on a few different directories. Results all look good, especially liking the krona reports.

I ran spacesavers2_grubbers --limit 0 separately, as none of the directories I tested had duplicate files over the default 5 GiB. It worked as expected.

I wonder if e2e should have also have a limit argument to pass on to grubbers with the same default value?

@kopardev
Copy link
Member Author

kopardev commented Feb 7, 2024

I wonder if e2e should have also have a limit argument to pass on to grubbers with the same default value?

It does

@kopardev
Copy link
Member Author

kopardev commented Feb 7, 2024

I fixed an issue in the e2e docs (bdee6d3) and also made minor updates to the changelog notes -- e.g. succinctly describing issue 71 so readers can get the gist of the fix without going to that issue.

Further updated docs (f72923a)

@kopardev
Copy link
Member Author

kopardev commented Feb 7, 2024

Currently, the output files from catalog, grubbers, and mimeo all start with a common prefix to encode the date, input directory, and user. However, the blame matrix is always called blamematrix.tsv -- should this file instead be renamed to include the same common prefix as the other files?

Done in 615f1ca .

@kopardev kopardev marked this pull request as ready for review February 8, 2024 00:00
@kopardev kopardev merged commit a1b6b92 into main Feb 8, 2024
1 check passed
@kopardev kopardev deleted the issue70 branch February 8, 2024 00:01
@kopardev
Copy link
Member Author

kopardev commented Feb 8, 2024

Also, fixes #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment