Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-z the only duplicates option for mimeo is not correctly implemented. #71

Closed
kopardev opened this issue Feb 1, 2024 · 0 comments · Fixed by #74
Closed

-z the only duplicates option for mimeo is not correctly implemented. #71

kopardev opened this issue Feb 1, 2024 · 0 comments · Fixed by #74
Assignees
Milestone

Comments

@kopardev
Copy link
Member

kopardev commented Feb 1, 2024

Observations:

  • duplicates are 2 and only 2 files are shown .. expectation is 3 files as original file should always be reported. This is likely when the original is owned by a different uid.
  • -z should only filter files out which do not have duplicates .. not filter out the original file as well

Scenario:

  • original file "a"
  • copied to "b"
  • "b" is then hardlinked to "c"
  • "c" is then copied to "d"
  • "d" is hardlinked to "e" and "f"

What will happen:

  • "a" through "f" all will have the same top_hash and bottom_hash, same size and account for 3 inodes
  • Hence, this should be 1 original + 2 duplicates even though you have 6 total files.
  • basically duplicate 2 duplicate inodes account for 6 files... so dup_bytes should by X 2 while usurp should replace 5 files with hard links
@kopardev kopardev self-assigned this Feb 1, 2024
@kopardev kopardev added this to the 2024-02 milestone Feb 1, 2024
@kopardev kopardev mentioned this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant