Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'dir' type and checkIfExists for Channel.fromPath #79

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Sep 19, 2023

Changes

  • Use nextflow's Channel.fromPath(type: 'dir') to construct a channel consisting of the directory of reference chromosomes for GEM.
    • Also use this same fix for fastq screen to avoid needing to bind mount the database directory.
  • Use checkIfExists: true in all Channel.fromPath calls to make sure an error is thrown if expected files don't exist.
  • Don't use $baseDir for paths. It was deprecated in favor of $projectDir.
    • GitHub Actions build workflow now runs all process stubs. Previously it couldn't find some files due to $baseDir.

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes. on hold until before public release
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool changed the title fix: GEM needs chromosomes dir, not list of files Use 'dir' type and checkIfExists for Channel.fromPath Sep 19, 2023
@kelly-sovacool kelly-sovacool self-assigned this Sep 19, 2023
@kelly-sovacool kelly-sovacool merged commit 25c520a into main Sep 19, 2023
1 check passed
@kelly-sovacool kelly-sovacool deleted the iss-78 branch September 19, 2023 18:04
@kelly-sovacool kelly-sovacool added this to the 2023w38_0922 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant