Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human data from encode + bug fixes #176

Merged
merged 14 commits into from
Feb 20, 2024
Merged

Add human data from encode + bug fixes #176

merged 14 commits into from
Feb 20, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Feb 19, 2024

Changes

This PR includes a number of loosely-related fixes:

  • add test human data from encode
  • allow shared inputs across samples in deeptools subworkflow
  • allow additional columns in samplesheet beyond minimal header
  • change peak widths histogram type from overlay to stack
  • add workflow entry point to download SRA (not yet integrated with rest of workflow)

Issues

towards #165, #169 (does not resolve)

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes. on hold until before public release
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool self-assigned this Feb 19, 2024
@kelly-sovacool kelly-sovacool changed the title Iss 169 Add human data from encode + bug fixes Feb 20, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review February 20, 2024 19:40
@kelly-sovacool kelly-sovacool merged commit 0544957 into main Feb 20, 2024
1 of 3 checks passed
@kelly-sovacool kelly-sovacool deleted the iss-169 branch February 20, 2024 19:44
@kelly-sovacool kelly-sovacool added this to the 2024-02 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant