Fixed docstrings | Added workflow for unit testing automation | Added more test cases | replaced pytest with unittest | Fixed dependencies bugs | #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, some docstrings for the MLP model creation with torch were not correct as the methods do not exist anymore. Will fix it later.
spirosmaggioros
changed the title
|
I reverted my additions for documentation files and created a different PR for those changes. |
…and macos automated test cases
spirosmaggioros
changed the title
|
I debugged the workflows using the additional test cases that i wrote. I will wait for this PR to be merged to make the new PR for the new test cases.
I will make seperate PR's for them as well. |
AlexanderGetka-cbica
approved these changes
Jul 17, 2024
|
Just waiting for the actions to run, then we'll merge. |
|
Note: I discussed the test cases with george and we concluded that we will use pytest, so i will change them again in the future. Right now we must concentrate to the code readability and syntax as well as the repo presentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced pytest with unittest library as i think for what we have right now on the repo it's easier for the workflow and for adding new unit tests.
There was some issues with the dependencies in dev-dependencies.txt and i updated some libraries to work for macos as well. I will update the workflow for multi-os support soon, i just wanted to tick the boxes right now for the unit testing automation. Right now it builds only for ubuntu-latest.
I also removed unused code, mostly unused parameters in functions and updated the docstrings wherever i could. I will add more docstrings and update the documentation manually the next days as well.
I also added a couple of test cases, i'm just waiting for this PR to merge to make anohter one, because if something from there wont actually merge to the main branch we will have conflicts.