Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code review for DLWMLS #2

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Initial code review for DLWMLS #2

merged 1 commit into from
Nov 14, 2024

Conversation

spirosmaggioros
Copy link
Member

@spirosmaggioros spirosmaggioros commented Nov 10, 2024

  • Added pre-commit bot checker
  • nnunet_ subfolders shouldn't be there as hugging face downlad them and in order to actually push these folders the user must have git LFS configured, which is not a good idea
  • A minor change in setup.py, the iteration on requirements.txt is not ideal as the requirements are meant for the devs, the user doesn't need to have all the packages installed.

…on setup.py(nothing special) | Remove nnunet_* subfolders
@spirosmaggioros spirosmaggioros self-assigned this Nov 10, 2024
@euroso97 euroso97 merged commit 1cdf459 into main Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants