feat(slo): improve burn rate panel (elastic#197339)

CAWilson94 · Nov 18, 2024 · a12a2a3 · a12a2a3
1 parent 4d55d5f
commit a12a2a3
Show file tree

Hide file tree

Showing 32 changed files with 599 additions and 579 deletions.
diff --git a/...ert_details/alert_details_app_section.tsx → ...ert_details/alert_details_app_section.tsx b/...ert_details/alert_details_app_section.tsx → ...ert_details/alert_details_app_section.tsx
@@ -9,8 +9,8 @@ import React, { useEffect } from 'react';
 import { EuiFlexGroup, EuiLink } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { AlertDetailsAppSectionProps } from '@kbn/observability-plugin/public';
-import { useKibana } from '../../../../hooks/use_kibana';
-import { useFetchSloDetails } from '../../../../hooks/use_fetch_slo_details';
+import { useKibana } from '../../hooks/use_kibana';
+import { useFetchSloDetails } from '../../hooks/use_fetch_slo_details';
 import { CustomAlertDetailsPanel } from './components/custom_panels/custom_panels';
 import { ErrorRatePanel } from './components/error_rate/error_rate_panel';
 import { BurnRateAlert, BurnRateRule } from './types';

diff --git a/...s/custom_panels/apm/apm_alert_details.tsx → ...s/custom_panels/apm/apm_alert_details.tsx b/...s/custom_panels/apm/apm_alert_details.tsx → ...s/custom_panels/apm/apm_alert_details.tsx
diff --git a/...nts/custom_panels/apm/embeddable_root.tsx → ...nts/custom_panels/apm/embeddable_root.tsx b/...nts/custom_panels/apm/embeddable_root.tsx → ...nts/custom_panels/apm/embeddable_root.tsx
diff --git a/...m_panels/custom_kql/custom_kql_panels.tsx → ...m_panels/custom_kql/custom_kql_panels.tsx b/...m_panels/custom_kql/custom_kql_panels.tsx → ...m_panels/custom_kql/custom_kql_panels.tsx
@@ -9,7 +9,7 @@ import { GetSLOResponse } from '@kbn/slo-schema';
 import React from 'react';
 import { LogRateAnalysisPanel } from './log_rate_analysis_panel';
 import { BurnRateAlert, BurnRateRule } from '../../../types';
-import { useLicense } from '../../../../../../../hooks/use_license';
+import { useLicense } from '../../../../../hooks/use_license';
 
 interface Props {
   slo: GetSLOResponse;

diff --git a/...ts__/log_rate_analysis_query.test.ts.snap → ...ts__/log_rate_analysis_query.test.ts.snap b/...ts__/log_rate_analysis_query.test.ts.snap → ...ts__/log_rate_analysis_query.test.ts.snap
diff --git a/...l/helpers/log_rate_analysis_query.test.ts → ...l/helpers/log_rate_analysis_query.test.ts b/...l/helpers/log_rate_analysis_query.test.ts → ...l/helpers/log_rate_analysis_query.test.ts
diff --git a/...om_kql/helpers/log_rate_analysis_query.ts → ...om_kql/helpers/log_rate_analysis_query.ts b/...om_kql/helpers/log_rate_analysis_query.ts → ...om_kql/helpers/log_rate_analysis_query.ts
diff --git a/...ls/custom_kql/log_rate_analysis_panel.tsx → ...ls/custom_kql/log_rate_analysis_panel.tsx b/...ls/custom_kql/log_rate_analysis_panel.tsx → ...ls/custom_kql/log_rate_analysis_panel.tsx
@@ -23,11 +23,11 @@ import { colorTransformer } from '@kbn/observability-shared-plugin/common';
 import { KQLCustomIndicator, DurationUnit } from '@kbn/slo-schema';
 import { i18n } from '@kbn/i18n';
 import type { Message } from '@kbn/observability-ai-assistant-plugin/public';
-import type { WindowSchema } from '../../../../../../../typings';
-import { TimeRange } from '../../../../../error_rate_chart/use_lens_definition';
+import type { WindowSchema } from '../../../../../typings';
+import { TimeRange } from '../../../../slo/error_rate_chart/use_lens_definition';
 import { BurnRateAlert, BurnRateRule } from '../../../types';
 import { getActionGroupFromReason } from '../../../utils/alert';
-import { useKibana } from '../../../../../../../hooks/use_kibana';
+import { useKibana } from '../../../../../hooks/use_kibana';
 import { getESQueryForLogRateAnalysis } from './helpers/log_rate_analysis_query';
 function getDataTimeRange(
   timeRange: { gte: string; lte?: string },

diff --git a/...omponents/custom_panels/custom_panels.tsx → ...omponents/custom_panels/custom_panels.tsx b/...omponents/custom_panels/custom_panels.tsx → ...omponents/custom_panels/custom_panels.tsx
diff --git a/...omponents/error_rate/error_rate_panel.tsx → ...omponents/error_rate/error_rate_panel.tsx b/...omponents/error_rate/error_rate_panel.tsx → ...omponents/error_rate/error_rate_panel.tsx
@@ -23,9 +23,9 @@ import { FormattedMessage } from '@kbn/i18n-react';
 import { ALERT_EVALUATION_VALUE, ALERT_TIME_RANGE } from '@kbn/rule-data-utils';
 import { GetSLOResponse } from '@kbn/slo-schema';
 import React from 'react';
-import { useKibana } from '../../../../../../hooks/use_kibana';
-import { ErrorRateChart } from '../../../../error_rate_chart';
-import { TimeRange } from '../../../../error_rate_chart/use_lens_definition';
+import { useKibana } from '../../../../hooks/use_kibana';
+import { ErrorRateChart } from '../../../slo/error_rate_chart';
+import { TimeRange } from '../../../slo/error_rate_chart/use_lens_definition';
 import { BurnRateAlert } from '../../types';
 import { getActionGroupWindow } from '../../utils/alert';
 import { getLastDurationInUnit } from '../../utils/last_duration_i18n';
@@ -153,7 +153,7 @@ export function ErrorRatePanel({ alert, slo, isLoading }: Props) {
               dataTimeRange={dataTimeRange}
               alertTimeRange={alertTimeRange}
               threshold={actionGroupWindow!.burnRateThreshold}
-              showErrorRateAsLine
+              variant="danger"
             />
           </EuiFlexItem>
         </EuiFlexGroup>

diff --git a/...ents/slo/burn_rate/alert_details/types.ts → .../public/components/alert_details/types.ts b/...ents/slo/burn_rate/alert_details/types.ts → .../public/components/alert_details/types.ts
@@ -7,8 +7,8 @@
 
 import type { Rule } from '@kbn/alerting-plugin/common';
 import type { TopAlert } from '@kbn/observability-plugin/public';
-import type { BurnRateRuleParams } from '../../../../typings/slo';
-export type { TimeRange } from '../../error_rate_chart/use_lens_definition';
+import type { BurnRateRuleParams } from '../../typings/slo';
+export type { TimeRange } from '../slo/error_rate_chart/use_lens_definition';
 
 export type BurnRateRule = Rule<BurnRateRuleParams>;
 export type BurnRateAlert = TopAlert;
diff --git a/...lo/burn_rate/alert_details/utils/alert.ts → ...c/components/alert_details/utils/alert.ts b/...lo/burn_rate/alert_details/utils/alert.ts → ...c/components/alert_details/utils/alert.ts
@@ -10,9 +10,9 @@ import {
   HIGH_PRIORITY_ACTION_ID,
   LOW_PRIORITY_ACTION_ID,
   MEDIUM_PRIORITY_ACTION_ID,
-} from '../../../../../../common/constants';
+} from '../../../../common/constants';
 import { BurnRateAlert } from '../types';
-import { WindowSchema } from '../../../../../typings';
+import { WindowSchema } from '../../../typings';
 
 export function getActionGroupFromReason(reason: string): string {
   const prefix = reason.split(':')[0]?.toLowerCase() ?? undefined;

diff --git a/...alert_details/utils/last_duration_i18n.ts → ...alert_details/utils/last_duration_i18n.ts b/...alert_details/utils/last_duration_i18n.ts → ...alert_details/utils/last_duration_i18n.ts
@@ -7,7 +7,7 @@
 
 import { i18n } from '@kbn/i18n';
 import moment from 'moment';
-import { TimeRange } from '../../../error_rate_chart/use_lens_definition';
+import { TimeRange } from '../../slo/error_rate_chart/use_lens_definition';
 
 export function getLastDurationInUnit(timeRange: TimeRange): string {
   const duration = moment.duration(moment(timeRange.to).diff(timeRange.from));

diff --git a/...rn_rate/alert_details/utils/time_range.ts → ...ponents/alert_details/utils/time_range.ts b/...rn_rate/alert_details/utils/time_range.ts → ...ponents/alert_details/utils/time_range.ts
@@ -6,7 +6,7 @@
  */
 import type { DateRange } from '@kbn/alerting-plugin/common';
 import { ALERT_TIME_RANGE } from '@kbn/rule-data-utils';
-import { TimeRange } from '../../../error_rate_chart/use_lens_definition';
+import { TimeRange } from '../../slo/error_rate_chart/use_lens_definition';
 import { BurnRateAlert } from '../types';
 import { getActionGroupWindow } from './alert';
 

diff --git a/x-pack/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate.test.tsx b/x-pack/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate.test.tsx
diff --git a/x-pack/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate.tsx b/x-pack/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate.tsx
diff --git a/...k/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate_header.tsx b/...k/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate_header.tsx