Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new proofreading schema #72

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dxenes1
Copy link

@dxenes1 dxenes1 commented Jan 20, 2023

  • This new schema would be used for reference tables with the target_id as a foreign key to the nucleus id in nucleus_neuron_svm.
  • Also adds 'roughly clean' and 'roughly extended' to the proofreading status enum to track neurons that have gone through some rounds of proofreading but are not comprehensively clean or extended.
  • Let me know if you'd like test cases added before merging.

@fcollman
Copy link
Collaborator

Sorry for the delay.. couple comments. These schemas are identical, there is no need for that... you can have the same schema and just put two different tables with different table names and different descriptions, just give the schema a more generic name and you can make the table name more specific.

Second, you forgot to give the new schema an entry in the init.py dictionary of schemas, that's our mapping from schema string to python class.

@dxenes1
Copy link
Author

dxenes1 commented Jan 26, 2023

Hi Forrest thanks for the review! Added the imports to the init.py file.

For the second class that is very similar to the first, we wanted a schema with no enum validation in the status_axon and status_dendrite fields to have a place to record our proofreading neurons with APL-specific proofreading status. I renamed this one GeneralProofreadingStatusReference to better fit its purpose. I can also move to a different PR or if there is a way to create a table with the CompartmentProofreadStatus and disable the validation that also works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants