Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible issue with synapse_query backwards compatibility #246

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

bdpedigo
Copy link
Collaborator

Due to the details of how the version checking decorator works, passing in (even empty) dictionaries to the new inequality filters would throw an error if running older versions of the materialization engine

@bdpedigo bdpedigo requested a review from kebwi October 14, 2024 19:07
@kebwi kebwi merged commit bccdad3 into master Oct 14, 2024
16 checks passed
@bdpedigo bdpedigo deleted the synapse-bug branch October 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants