Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fdb] add v5.11.17 #848

Merged
merged 15 commits into from
Oct 30, 2023
Merged

[fdb] add v5.11.17 #848

merged 15 commits into from
Oct 30, 2023

Conversation

victoria-cherkas
Copy link
Contributor

@victoria-cherkas victoria-cherkas commented Oct 26, 2023

Adds fdb release 5.11.17 (backport of spack/spack#40571)
Does not run system test on tsa as a result of error 'UCX WARN transports', which is unrelated to FDB.

@victoria-cherkas victoria-cherkas marked this pull request as ready for review October 26, 2023 11:47
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-30 15:03 UTC

@victoria-cherkas victoria-cherkas changed the title [fdb] add v5.11.17 [fdb] add v5.11.17 and v5.11.23 Oct 26, 2023
@dominichofer
Copy link
Contributor

launch jenkins fdb

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢fdb-spack_info
🔴 system test
Test
🟢Fdb-install_5_11_17_gcc
🟢Fdb-install_5_11_17_nvhpc
🔴Fdb-install_5_11_23_gcc
🔴Fdb-install_5_11_23_nvhpc

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢fdb-spack_info
🔴 system test
Test
🔴Fdb-install_5_11_17_gcc
🟢Fdb-install_5_11_17_nvhpc
🔴Fdb-install_5_11_23_gcc
🔴Fdb-install_5_11_23_nvhpc

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢fdb-spack_info
🔴 system test
Test
🟢Fdb-install_5_11_17_gcc
🟢Fdb-install_5_11_17_nvhpc
🔴Fdb-install_5_11_23_gcc
🔴Fdb-install_5_11_23_nvhpc

WARNING: Serial tests did not run for system tests

@C2SM C2SM deleted a comment from jenkins-apn Oct 27, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 27, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 27, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 27, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 27, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 27, 2023
@dominichofer
Copy link
Contributor

dominichofer commented Oct 27, 2023

spack install fdb @5.11.17 %gcc failed on Tsa due to "Test #29: FDB-307.sh".
spack install fdb @5.11.23 could not find a configuration file for package "eckit" that is compatible with requested version "1.24.4".

@dominichofer
Copy link
Contributor

@victoria-cherkas
Copy link
Contributor Author

@dominichofer thanks looking into it!

@victoria-cherkas
Copy link
Contributor Author

victoria-cherkas commented Oct 27, 2023

Thanks for pointing this out, I hadnt noticed this new dependency. Added PR in spack fdb: spack/spack#40737

But I would perhaps suggest that I just remove [email protected] from this PR, since the eckit later version additions will come from the next spack release anyway. Do you agree @dominichofer ?

@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@victoria-cherkas
Copy link
Contributor Author

launch jenkins fdb

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢fdb-spack_info

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢fdb-spack_info
🟢 system test
Test
🟢Fdb-install_5_11_17_gcc
🟢Fdb-install_5_11_17_nvhpc

@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@C2SM C2SM deleted a comment from jenkins-apn Oct 30, 2023
@victoria-cherkas
Copy link
Contributor Author

victoria-cherkas commented Oct 30, 2023

As agreed with @dominichofer we will not run FDB system tests on Tsa because of mysterious error unrelated to FDB that would take a long time to debug, not worth the effort given this is only a temporary backport:

[1698423430.470244] [tsa-pp008:238338:0] ucp_context.c:690 UCX WARN transports 'cuda_copy','cuda_ipc' are not available, please use one or more of: cma, dc, dc_mlx5, dc_x, ib, knem, mm, posix, rc, rc_mlx5, rc_v, rc_verbs, rc_x, self, shm, sm, sysv, tcp, ud, ud_mlx5, ud_v, ud_verbs, ud_x https://jenkins-mch.cscs.ch/job/Spack/job/spack_PR/1368/artifact/log/tsa/system_test/Fdb-install_5_11_17_gcc.log/*view*/

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢fdb-spack_info
🟢 system test
Test
🟢Fdb-install_5_11_17_gcc
🟢Fdb-install_5_11_17_nvhpc

@victoria-cherkas victoria-cherkas changed the title [fdb] add v5.11.17 and v5.11.23 [fdb] add v5.11.17 Oct 30, 2023
@lxavier
Copy link
Contributor

lxavier commented Oct 30, 2023

Code was reviewed by @dominichofer already. All test green I will merge.

@lxavier lxavier merged commit 3d9ffbc into main Oct 30, 2023
@lxavier lxavier deleted the fdb branch October 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants