Use new itir.Program everywhere #596
Conversation
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
| @@ -445,8 +446,8 @@ def _get_offset_providers(self, grid: icon_grid.IconGrid) -> dict[str, gtx.Field | |||
| horizontal_offsets = { | |||
| k: v | |||
| for k, v in grid.offset_providers.items() | |||
| if isinstance(v, gtx.NeighborTableOffsetProvider) | |||
| and v.origin_axis.kind == gtx.DimensionKind.HORIZONTAL | |||
| if isinstance(v, gtx.Connectivity) | |||
There was a problem hiding this comment.
We should be able to remove this workaround with PR 1746...
|
cscs-ci run default |
|
cscs-ci run dace |
pyproject.toml
Outdated
| @@ -109,8 +109,7 @@ explicit = true | |||
|
|
|||
| [tool.uv.sources] | |||
| # ghex = { git = "https://github.com/ghex-org/GHEX.git", branch = "master"} | |||
| # TODO(egparedes): use GT4Py tagged release until #596 & gt4py#1738 are merged | |||
| gt4py = { git = "https://github.com/GridTools/gt4py", tag = "icon4py_20241113" } | |||
| gt4py = { git = "https://github.com/GridTools/gt4py.git", branch = "main" } | |||
There was a problem hiding this comment.
I took the freedom to update this PR and merge the latest icon4py main, in order to include the uv development environment.
While merging, I reverted a change from @havogt, that used a custom gt4py branch. If needed, you can re-apply it by changing this line:
| gt4py = { git = "https://github.com/GridTools/gt4py.git", branch = "main" } | |
| gt4py = { git = "https://github.com/havogt/gt4py.git", branch = "increase_inlining_loop" } |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
Blocked by
GridTools/gt4py#1738,GridTools/gt4py#1648